Comments on: Refactoring 3: Replace Temp with Query

By: mathk

mathk — Tue, 18 Aug 2009 07:35:04 +0000

I also see a main avantage:
If you ever decide to add a new item with a new way of computing the discount you just have to subclass your item and redefine the dicount_factor() method. Nothing more!

By: Favio

Favio — Fri, 07 Aug 2009 08:26:53 +0000

What do you think about writing the discount_factor function as:

private function discount_factor() {
if($this->base_price() > 1000) {
return 0.95;
}
return 0.98;
}

Anyway, you have a cool blog.

By: Refactoring 3: Replace Temp with Query : CodeDiesel

Refactoring 3: Replace Temp with Query : CodeDiesel — Sat, 04 Jul 2009 07:34:39 +0000

[...] the original post here: Refactoring 3: Replace Temp with Query : CodeDiesel Share and [...]

By: Jon

Jon — Wed, 10 Jun 2009 12:34:02 +0000

Thanks for this, great refactoring articles!

By: Raphaël Dehousse

Raphaël Dehousse — Mon, 08 Jun 2009 13:29:22 +0000

Hello,

Ok for the pattern but in your example, I would rather write :

private function discount_factor($base_price) {
if($base_price > 1000)
return 0.95;
else
return 0.98;
}

public function get_price() {
$base_price = $this->base_price();

return ($base_price * $this->discount_factor($base_price));
}

You will save one function call and like this, you can use discount_factor on other price than the base one of your class

Thanks for your articles !

Cheers,

Raphaël